fix(ivy): wrap functions from "providers" in parentheses in Closure mode #33609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
state: WIP
target: patch
AndrewKushnir
force-pushed
the
FW-1662_providers_with_closure
branch
from
623ba11
to
face365
Compare
AndrewKushnir
added
action: review
petebacondarwin
approved these changes
Nov 6, 2019
| } | ||
| return visited; | ||
| }; | ||
| return (node: ts.Expression) => ts.visitEachChild(node, visitor, context); |
There was a problem hiding this comment.
Suggested change
| return (node: ts.Expression) => ts.visitEachChild(node, visitor, context); | |
| return node => ts.visitEachChild(node, visitor, context); |
AndrewKushnir
force-pushed
the
FW-1662_providers_with_closure
branch
from
e7a7f9e
to
4f6b3ca
Compare
|
@petebacondarwin @alxhub thanks for the review! I've updated this PR based on the comments:
Could you please have a quick look again and let me know if you have additional feedback? Thank you. |
AndrewKushnir
added
the
action: presubmit
petebacondarwin
approved these changes
Nov 14, 2019
Due to the fact that Tsickle runs between analyze and transform phases in Angular, Tsickle may transform nodes (add comments with type annotations for Closure) that we captured during the analyze phase. As a result, some patterns where a function is returned from another function may trigger automatic semicolon insertion, which breaks the code (makes functions return `undefined` instead of a function). In order to avoid the problem, this commit updates the code to wrap all functions in some expression ("privders" and "viewProviders") in parentheses. More info can be found in Tsickle source code here: https://github.com/angular/tsickle/blob/d7974262571c8a17d684e5ba07680e1b1993afdd/src/jsdoc_transformer.ts#L1021
AndrewKushnir
force-pushed
the
FW-1662_providers_with_closure
branch
from
4f6b3ca
to
4de646c
Compare
alxhub
approved these changes
Nov 19, 2019
AndrewKushnir
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Nov 20, 2019
…ode (#33609) Due to the fact that Tsickle runs between analyze and transform phases in Angular, Tsickle may transform nodes (add comments with type annotations for Closure) that we captured during the analyze phase. As a result, some patterns where a function is returned from another function may trigger automatic semicolon insertion, which breaks the code (makes functions return `undefined` instead of a function). In order to avoid the problem, this commit updates the code to wrap all functions in some expression ("privders" and "viewProviders") in parentheses. More info can be found in Tsickle source code here: https://github.com/angular/tsickle/blob/d7974262571c8a17d684e5ba07680e1b1993afdd/src/jsdoc_transformer.ts#L1021 PR Close #33609
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that Tsickle runs between analyze and transform phases in Angular, Tsickle may transform nodes (add comments with type annotations for Closure) that we captured during the analyze phase. As a result, some patterns where a function is returned from another function may trigger automatic semicolon insertion, which breaks the code (makes functions return
undefinedinstead of a function). In order to avoid the problem, this commit updates the code to wrap all functions in some expression ("privders" and "viewProviders") in parentheses. More info can be found in Tsickle source code here: https://github.com/angular/tsickle/blob/d7974262571c8a17d684e5ba07680e1b1993afdd/src/jsdoc_transformer.ts#L1021PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?